✅ Deploy Preview for viteplus-preview canceled.

Maybe I should learn https://fengmk2.com/posts/blog-qwin-windows-testing-on-macos carefully haha.

Maybe I should learn https://fengmk2.com/posts/blog-qwin-windows-testing-on-macos carefully haha.

don't do that, it was slop. I only test on real windows by hand.

@codex review

This fix will require us to adapt any new executables added to the bin directory in Node.js in the future, and it will be difficult to spot the problem. Maintaining the current implementation is actually to be expected, since users install the global CLI via npm install -g, and it's expected they will have access to it.

Emm, so let's close it.

Vite+ now prepends node's bin directory to $PATH, in this directory, it includes not only core Node.js tools, but other installed tools, like npm install -g typescript's tsc. It can't be access directly from shells, but this prepending makes it accessible from scripts.

Another edge case: if you use Node.js to launch your terminal / editor (like @liangmi/mo), the shell's $PATH will include the Node's bin as well. When this runtime's bin is included, npm install -g will stop prompting users to add bins. Make you can't access this bin anymore after you exist this terminal.

@fengmk2 However, I still think there is room to improve the current behavior. Actually, in my opinion, the current npm install -g seems kind of strange, its current duty is similar to vp install -g, and our modify (hooks) make its behavior change in different cases.

I've checked #528, #540. According to them, if I have a chance to re-design the vp env system, I will make Vite+ always inject runtime's bin directory to $PATH, let npm do not have any wrapper, and make the bin only usable when using the node used to install it. I believe it is a approach to keep code and behavior both clean.

Alternatively, we could improve this by intercepting npm install -g and prompting the user to use vp install -g instead.

Trace in #1986